Update support data for Chrome Android (API's A through F) #18359

jugglinmike · 2022-12-02T20:50:21Z

Summary

These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2].

[1] https://github.com/foolip/mdn-bcd-collector
commit 06ea2714451c548934849011e4106b3175adfab5
[2] https://github.com/foolip/mdn-bcd-results
commit f37e6db1da24143bf039ed8e269c9f234d2b4e90

Test results and supporting details

Related issues

This changeset is based on the one originally submitted via #17908. It uses compatibility data which has been collected since that patch was created, and it includes only a subset of the changes generated by the mdn-bcd-collector.

These changes were generated procedurally by the mdn-bcd-collector project [1] using data collected from Chrome for Android [2]. [1] https://github.com/foolip/mdn-bcd-collector commit 06ea2714451c548934849011e4106b3175adfab5 [2] https://github.com/foolip/mdn-bcd-results commit f37e6db1da24143bf039ed8e269c9f234d2b4e90

The commit "Enable drag and drop on Android platform by default" was released in version 54: https://chromereleases.googleblog.com/2016/10/chrome-for-android-update.html

github-actions · 2022-12-18T05:09:11Z

This pull request has merge conflicts that must be resolved before it can be merged.

foolip · 2023-01-04T05:41:53Z

api/BrowserCaptureMediaStreamTrack.json

@@ -7,7 +7,9 @@
          "chrome": {
            "version_added": "104"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


Confirmed by https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=2311-2312;drc=8c770f58ec30541481bb61c02712c0fa2dbd685d

foolip · 2023-01-04T05:44:07Z

api/CSPViolationReportBody.json

@@ -8,7 +8,9 @@
          "chrome": {
            "version_added": "74"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


https://mdn-bcd-collector.appspot.com/tests/api/CSPViolationReportBody returns false on desktop as well. The problem here was the use of [NoInterfaceObject] and was recently fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=1122656

We should maybe still update this data somehow, but it's not a difference between desktop and Android, so I suggest splitting out this change.

foolip · 2023-01-04T05:44:30Z

api/CrashReportBody.json

@@ -8,7 +8,9 @@
          "chrome": {
            "version_added": "72"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


This is also a case of https://bugs.chromium.org/p/chromium/issues/detail?id=1122656.

foolip · 2023-01-04T05:44:46Z

api/DeprecationReportBody.json

@@ -8,7 +8,9 @@
          "chrome": {
            "version_added": "69"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


This is also a case of https://bugs.chromium.org/p/chromium/issues/detail?id=1122656.

foolip · 2023-01-04T05:48:36Z

api/DOMMatrixReadOnly.json

@@ -1636,7 +1636,9 @@
            "chrome": {
              "version_added": "61"
            },
-            "chrome_android": "mirror",
+            "chrome_android": {
+              "version_added": false


https://mdn-bcd-collector.appspot.com/tests/api/DOMMatrixReadOnly/transform says no support in Chrome desktop as well. And in fact for Firefox and Safari. This appears to be a ghost feature, I can't find any information about it. Should be removed from BCD.

foolip · 2023-01-04T08:58:34Z

api/Element.json

@@ -3671,7 +3685,9 @@
            "chrome": {
              "version_added": "1"
            },
-            "chrome_android": "mirror",
+            "chrome_android": {
+              "version_added": false


This is a bad test, removing it in foolip/mdn-bcd-collector#2640.

foolip · 2023-01-04T09:01:53Z

api/ElementInternals.json

@@ -246,7 +246,9 @@
            "chrome": {
              "version_added": "81"
            },
-            "chrome_android": "mirror",
+            "chrome_android": {
+              "version_added": false


The desktop data is wrong here, this property isn't in Chromium.

foolip · 2023-01-04T09:02:14Z

api/ElementInternals.json

@@ -1128,7 +1130,9 @@
            "chrome": {
              "version_added": "81"
            },
-            "chrome_android": "mirror",
+            "chrome_android": {
+              "version_added": false


The desktop data is wrong here, this property isn't in Chromium.

foolip · 2023-01-04T09:52:17Z

api/FileSystem.json

@@ -8,7 +8,9 @@
          "chrome": {
            "version_added": "7"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


https://mdn-bcd-collector.appspot.com/tests/api/FileSystem says no support on desktop either, so I don't trust this. I'll assume all of the FileSystem* changes that follow are similarly suspect and skip over them in review.

foolip · 2023-01-04T09:54:04Z

api/FontData.json

@@ -7,7 +7,9 @@
          "chrome": {
            "version_added": "103"
          },
-          "chrome_android": "mirror",
+          "chrome_android": {
+            "version_added": false


Confirmed by https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=1347-1349;drc=8c770f58ec30541481bb61c02712c0fa2dbd685d

And window.queryLocalFonts is already correctly set to not supported on Android.

queengooborg · 2023-01-09T16:46:52Z

By the way, due to how many different APIs this touches, it would be much better to split it into much, MUCH smaller chunks, such as per API or interface grouping (ex. all picture-in-picture features). Additionally, this will help ensure that this doesn't keep on running to merge conflicts during the review, and each bit can be merged much quicker.

foolip · 2023-01-16T05:58:23Z

Since the verified correct changes of this and the other 3 PRs are the minority of the changes, I'd actually suggest just splitting those into a single a trivial-to-merge PR. The rest is basically bookkeeping for things we need to do to avoid these incorrect changes showing up in the future again.

jugglinmike · 2023-01-19T01:10:47Z

Thank you, @foolip! I expect to have time to help wrap this up (along with gh-18360, gh-18361, and gh-18362) in early February.

github-actions · 2023-03-03T12:01:24Z

This pull request has merge conflicts that must be resolved before it can be merged.

Elchi3 · 2023-06-22T15:33:29Z

Given how much iteration there has been on the collector project since this PR was opened (December 2022), I am going to close this.

jugglinmike added 2 commits December 2, 2022 15:35

Specify changes

8a44897

The commit "Enable drag and drop on Android platform by default" was released in version 54: https://chromereleases.googleblog.com/2016/10/chrome-for-android-update.html

github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 2, 2022

jugglinmike mentioned this pull request Dec 2, 2022

Update support data for Chrome Android #17908

Closed

github-actions bot added the rebase needed 🚧 label Dec 18, 2022

foolip requested changes Jan 4, 2023

View reviewed changes

This was referenced Jan 5, 2023

Update support data for Chrome Android (API's G through M) #18360

Closed

Update support data for Chrome Android (API's N through S) #18361

Closed

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 3, 2023

bsmth removed the rebase needed 🚧 label Mar 3, 2023

Elchi3 closed this Jun 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update support data for Chrome Android (API's A through F) #18359

Update support data for Chrome Android (API's A through F) #18359

jugglinmike commented Dec 2, 2022

github-actions bot commented Dec 18, 2022

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

foolip Jan 4, 2023

queengooborg commented Jan 9, 2023

foolip commented Jan 16, 2023

jugglinmike commented Jan 19, 2023

github-actions bot commented Mar 3, 2023

Elchi3 commented Jun 22, 2023

Update support data for Chrome Android (API's A through F) #18359

Update support data for Chrome Android (API's A through F) #18359

Conversation

jugglinmike commented Dec 2, 2022

Summary

Test results and supporting details

Related issues

github-actions bot commented Dec 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

queengooborg commented Jan 9, 2023

foolip commented Jan 16, 2023

jugglinmike commented Jan 19, 2023

github-actions bot commented Mar 3, 2023

Elchi3 commented Jun 22, 2023